Add :accessor for avoiding defining accessors#42
Open
janko wants to merge 1 commit intoapotonick:masterfrom
Open
Add :accessor for avoiding defining accessors#42janko wants to merge 1 commit intoapotonick:masterfrom
janko wants to merge 1 commit intoapotonick:masterfrom
Conversation
If we have an accessor defined before declaring a property in an
included module, it will get overriden. The :accessor option allows
us to specify whether we want Disposable::Twin to define accessors for
that property.
module Titleable
def title
# ...
end
def title=(value)
# ...
end
end
class Song < Disposable::Twin
include Titleable
property :title, accessor: false
end
Author
|
I realized that this is a too specific use case, I just got around it in Shrine by overriding |
Owner
|
I might have another use case for that... |
Author
|
Sure thing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we have an accessor defined before declaring a property in an included module, it will get overriden. The
:accessoroption allows us to specify whether we want Disposable::Twin to define accessors for that property.I know this is probably a fairly uncommon scenario, but I needed this in Shrine.